Fix attachment delivery urls #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Feb 26, 2021
dkanada
approved these changes
Feb 27, 2021
thornbill
approved these changes
Feb 27, 2021
joshuaboniface
pushed a commit
that referenced
this pull request
Feb 28, 2021
Fix attachment delivery urls (cherry picked from commit 0a342ce) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return missed
apiClient.getUrlcall (initially was added in d3c0bdd).Was accidentally (?) removed in 86c8744
Changes
Return missed
apiClient.getUrl.Issues
SubtitlesOctopus fails to load attachments in case of embedded webui (Tizen app) - base URL is app URL instead of server URL.
Probably jellyfin/jellyfin-tizen#62 and jellyfin/jellyfin-tizen#64