Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Oculus browser is no longer marked as TV #3231

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

emilrowland
Copy link
Contributor

Changes

Changed the browser feature detection to correctly identify the oculus browser. Now all features are working and the oculus browsers built in VR support is also working for 3D videos.

@dmitrylyzo
Copy link
Contributor

So you need Jellyfin to be like Desktop (mouse, resize), right?
Or are there other features?

@emilrowland
Copy link
Contributor Author

Yes VR version of web pages are usually the Desktop version if not a specific VR version of the page.
For Jellyfin the Desktop page works great on my VR setup. You have access to everything that you would need in VR like Download and full screen support of the Video player, that wasn't available when it thought my Oculus Setup was an TV.

But there is no need for anymore features.

src/scripts/browser.js Outdated Show resolved Hide resolved
@dmitrylyzo
Copy link
Contributor

dist.tar?

@emilrowland
Copy link
Contributor Author

Sorry, noticed my build file there. Will remove now.

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thornbill thornbill merged commit aeb357c into jellyfin:master Dec 27, 2021
@emilrowland emilrowland deleted the bug/oculus branch December 27, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants