Fix undefined serverId in Person card #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should avoid using browser globals… you might be able to use a function in |
viown
force-pushed
the
fix-undefined-serverid
branch
from
eb354f9
to
c32b3fd
Compare
thornbill
reviewed
Aug 15, 2024
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
viown
force-pushed
the
fix-undefined-serverid
branch
from
cf484d4
to
86e3ea8
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Aug 20, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Aug 25, 2024
Fix undefined serverId in Person card Original-merge: d470238 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes undefined 'serverId' for the person cards under 'Cast & Crew' and possibly in other places as well.
Issues