Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme.md #177

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Updated readme.md #177

merged 8 commits into from
Feb 8, 2024

Conversation

harmonytke
Copy link
Contributor

Updated Readme file to updated commands and jdk version

@harmonytke
Copy link
Contributor Author

@walisc updated PR

@walisc
Copy link
Collaborator

walisc commented Feb 8, 2024

@walisc updated PR

Thanks for this @harmonytke . Have left a few comments above. Looking good besides!

.github/workflows/jempiUI.yml Outdated Show resolved Hide resolved
.github/workflows/jempiUI.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@harmonytke
Copy link
Contributor Author

Ready

@walisc updated PR

Thanks for this @harmonytke . Have left a few comments above. Looking good besides!

Thank you, updated changes

Copy link
Collaborator

@walisc walisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this @harmonytke !

@walisc walisc merged commit d3222b5 into jembi:dev Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants