-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-86c095u7n - Default setup to use Keycloak #320
CU-86c095u7n - Default setup to use Keycloak #320
Conversation
Task linked: CU-86c095u7n Default setup to use Keycloak |
WalkthroughThe changes involve updates to environment variable exports in a shell script, modifications to a Keycloak JSON configuration, enhancements to a deployment script, and documentation adjustments. Environment variables related to API port and Single Sign-On (SSO) functionality were activated with new values. The Keycloak realm configuration was simplified by changing the password handling mechanism and adding a temporary field. Additionally, a deployment script was modified to conditionally start a Keycloak test server based on the SSO setting, while the documentation reflected the updated password format. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeployScript
participant Keycloak
User->>DeployScript: Run deployment
DeployScript->>DeployScript: Check REACT_APP_ENABLE_SSO
alt SSO Enabled
DeployScript->>Keycloak: Start Keycloak test server
end
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- devops/linux/docker/conf/env/create-env-linux-low-1.sh (1 hunks)
- devops/linux/docker/conf/keycloak/import-jempi-dev-realm.json (1 hunks)
- devops/linux/docker/deployment/deploy-local.sh (1 hunks)
- devops/linux/docker/deployment/scripts/d-stack-up-app-containers.sh (1 hunks)
- documentation/keycloak/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- documentation/keycloak/README.md
Additional comments not posted (3)
devops/linux/docker/deployment/scripts/d-stack-up-app-containers.sh (1)
29-34
: LGTM!The changes to conditionally start the Keycloak test server based on the
REACT_APP_ENABLE_SSO
environment variable look good. The script is correctly sourced within apushd
andpopd
block to ensure the correct directory context.devops/linux/docker/conf/env/create-env-linux-low-1.sh (1)
65-66
: LGTM!The changes to update the values of
REACT_APP_JEMPI_BASE_API_PORT
andREACT_APP_ENABLE_SSO
environment variables look good. The previous commented-out lines defining these variables have been correctly removed.Also applies to: 68-69
devops/linux/docker/deployment/deploy-local.sh (1)
77-77
: LGTM!The change to source the SDKMAN initialization script after installing sbt in the
install_sdkman_and_java_sbt_maven
function looks good. This ensures that the SDKMAN environment is properly set up for subsequent commands.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation