-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade adaptor version project.yaml #329
upgrade adaptor version project.yaml #329
Conversation
This project's new adaptor has a new release and is under a different adaptor name ("fhir-ndr-et")
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Aleksa
@drizzentic if you merge this and pull this
project.yaml
file to update your local workflow config, this will ensure your local workflow is using the latest adaptor version:fhir-ndr-et@0.1.0
. If looks like this adaptorfhir-ndr-et
is not available in your local openfn instance, you can pull again from the lightning docker image (2.9.5).This is not a critical update, but it will introduce two changes:
fhir-jembi
tofhir-ndr-et
to better match this project (fyi see adaptor docs)text
values associated with codes are outputted in the payloads processed by the openfn workflow. The requests to the NDR FHIR api were succeeding even without this in our tests, but it will ensure the mapped CDR payloads match 100% with the NDR examples and spec.