The config importer [will minimize the issue] #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashboard-visualiser-kibana/swarm.sh
Outdated
| @@ -42,6 +42,22 @@ configure_nginx() { | |||
| fi | |||
| } | |||
|
|
|||
| AwaitServiceTojoinNetwork() { | |||
There was a problem hiding this comment.
If we're going to implement this function in a few places, it's probably worth writing this into a utility function and inserting that in config-utils.sh.
There was a problem hiding this comment.
Yea yea you're right 👍
There was a problem hiding this comment.
Please remove this function, it's no longer referenced
dashboard-visualiser-kibana/swarm.sh
Outdated
| @@ -42,6 +42,22 @@ configure_nginx() { | |||
| fi | |||
| } | |||
|
|
|||
| AwaitServiceTojoinNetwork() { | |||
There was a problem hiding this comment.
Please remove this function, it's no longer referenced
utils/config-utils.sh
Outdated
| local start_time=$(date +%s) | ||
| local exit_time=30 | ||
| local warning_time=10 | ||
| local timer=0 |
There was a problem hiding this comment.
Unreferenced variable
Suggested change
| local timer=0 |
| config::await_network_join() { | ||
| echo "Waiting for elasticsearch service to join network..." | ||
|
|
||
| local -r SERVICE_NAME="${1:?"FATAL: await_service_removed SERVICE_NAME not provided"}" |
rcrichton
reviewed
Jun 29, 2022
rcrichton
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the elasticsearch service will join the network after some time.
An error ENOTFOUND will occur if the config importer send the config before elasticsearch join the network.
So, we added a loop that will wait for elasticsearch to join the network.
With this fix, the config importer issue will not occur again.
But, with this fix the code will exit with error and the config importer will not be executed.
This issue still rarely exists with elasticsearch and other services as well.