New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog cannot dispose buttons with no ID #37

Closed

Jemt opened this issue Jul 21, 2018 · 1 comment

Labels

bug

Owner

Jemt commented Jul 21, 2018 •

edited

Loading

Adding a button to a Dialog instant that has not been instantiated with an ID will trigger an error when the dialog is disposed.

http://jsfiddle.net/Jemt/wqfzus50/2/

Work around: Pass an ID to the button in the constructor.

Jemt added the bug label

Jemt changed the title ~~Dialog cannot dispose buttons with IDs~~ Dialog cannot dispose buttons with no ID

Owner Author

Jemt commented Jul 26, 2018

This has been resolved with the work on #39. Commit: d818b4e#diff-9c0ac808a7a8053a98e950e32ac76b50R303

Jemt closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment