Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with hashtag symbols in url. Issue #556 #703

Merged
merged 5 commits into from
Jun 10, 2023

Conversation

laraconda
Copy link
Contributor

@laraconda laraconda commented Jun 1, 2023

Summary of the changes in this pull request

  • Editor now avoids marking cpp directives as hashtags
  • Editor now correctly colors urls containing '#' symbols
  • TODO

Pull request checklist

  • I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
  • If applicable: I have removed the corresponding entry in TODO.md.

@laraconda
Copy link
Contributor Author

I unfortunately discovered a new issue regarding pattern recognition. In preview mode urls and hashtags cause problems. This is related to the processing made by t2t. I'll open a new issue to discuss details there.

Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Please also add a short changelog entry.

rednotebook/files/t2t.lang Outdated Show resolved Hide resolved
@jendrikseipp jendrikseipp merged commit 53bfab8 into jendrikseipp:master Jun 10, 2023
@jendrikseipp
Copy link
Owner

Thanks!

@laraconda laraconda deleted the url-hashtag branch June 10, 2023 16:56
jendrikseipp pushed a commit to laraconda/rednotebook that referenced this pull request May 5, 2024
…#703)

* Fixing url not recognized when hashtag symbol is followed by slash. Issue jendrikseipp#556
* Adding more cpp directives to hashtag pattern in t2t. Adding comment regarding what each hashtag regex is used for in both files.
---------
Co-authored-by: Jendrik Seipp <jendrikseipp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants