Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dark Mode #50

Merged
merged 3 commits into from
May 16, 2020
Merged

Enable Dark Mode #50

merged 3 commits into from
May 16, 2020

Conversation

grvpanchal
Copy link
Contributor

@grvpanchal grvpanchal commented May 16, 2020

Following Changes made:

  • Added three variables --bg-color for body background, --font-color for default font color, --bg-al-color for blockquote, table.striped, pre and kbd
  • Updated docs on how to apply dark mode
  • Confirmed tests with dark mode
  • Added dark mode switch to docs and tests

Copy link
Owner

@jenil jenil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @grvpanchal, Thanks for this! Looks good mostly, left a few comments.

src/_base.css Outdated Show resolved Hide resolved
src/_base.css Outdated Show resolved Hide resolved
src/_base.css Outdated Show resolved Hide resolved
src/_base.css Outdated Show resolved Hide resolved
src/_base.css Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@jenil jenil self-assigned this May 16, 2020
@jenil jenil merged commit 954ac66 into jenil:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants