Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ldap) allow customization of the LB service for Azure #933

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 9, 2023

Related to jenkins-infra/helpdesk#3683 (comment)

Checked on the production with the following values:

service:
  type: LoadBalancer
  # Public IPv4 defined as code in https://github.com/jenkins-infra/azure/blob/main/ldap.jenkins.io.tf instead of requesting a random new public IP, useful for DNS setup and changes
  azurePip:
    name: ldap-jenkins-io-ipv4
    resourceGroup: prod-public-ips
  whitelisted_sources:
# ...

result is:

ldap, ldap, Service (v1) has changed:
...
    labels:
      app.kubernetes.io/name: ldap
-     helm.sh/chart: ldap-0.2.1
+     helm.sh/chart: ldap-0.3.0
      app.kubernetes.io/instance: ldap
      app.kubernetes.io/managed-by: Helm
+   annotations:
+     service.beta.kubernetes.io/azure-pip-name: ldap-jenkins-io-ipv4
+     service.beta.kubernetes.io/azure-load-balancer-resource-group: prod-public-ips
  spec:
    type: LoadBalancer
-   loadBalancerIP: 20.7.180.148
    loadBalancerSourceRanges:
      - "20.85.71.108/32"

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added enhancement New feature or request ldap labels Nov 9, 2023
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dduportal dduportal merged commit a6574a1 into jenkins-infra:main Nov 9, 2023
5 checks passed
@dduportal dduportal deleted the feat/ldap/svc-annotations branch November 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ldap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants