Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(buildDockerAndPublishImage): annotate GitHub release with make show output #834

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jan 27, 2024

This PR annotates GitHub release with the output from make show allowing to know which target(s) and tag(s) have been published, and which settings have been used for the release.

Tested on https://github.com/jenkins-infra/docker-confluence-data/ with success: https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.1.39

Release body content output: image

Note: easier to review without whitespace changes, see https://github.com/jenkins-infra/pipeline-library/pull/834/files?diff=unified&w=1

Ref:

lemeurherve added a commit to jenkins-infra/docker-confluence-data that referenced this pull request Feb 9, 2024
lemeurherve added a commit to jenkins-infra/docker-confluence-data that referenced this pull request Feb 9, 2024
@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 9, 2024

MarkEWaite
MarkEWaite previously approved these changes Feb 9, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I did not test it myself locally. @lemeurherve can you confirm that you tested the subset of the script locally?

@lemeurherve
Copy link
Member Author

Yes.

@dduportal
Copy link
Contributor

Do you have an example of the output?

@hervelemeur
Copy link

Do you have an example of the output?

Yes, see above: #834 (comment)

@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 9, 2024

Release body content output:
<!-- Optional: add a release summary here -->
## ✍ Other changes

* chore: add dockerhub badge (#55) @lemeurherve

## :memo: Release settings

<details>

```json
{
  "target": {
    "default": {
      "context": "/home/jenkins/workspace/bs_docker-confluence-data_0.1.35",
      "dockerfile": "/home/jenkins/workspace/bs_docker-confluence-data_0.1.35/Dockerfile",
      "args": {
        "BUILD_DATE": "2024-02-09T15:35:16Z",
        "GIT_COMMIT_REV": "12f63021",
        "GIT_SCM_URL": "https://github.com/jenkins-infra/docker-confluence-data.git"
      },
      "labels": {
        "org.label-schema.build-date": "2024-02-09T15:35:16Z",
        "org.label-schema.url": "\"https://github.com/jenkins-infra/docker-confluence-data.git\"",
        "org.label-schema.vcs-ref": "12f63021",
        "org.label-schema.vcs-url": "https://github.com/jenkins-infra/docker-confluence-data.git",
        "org.opencontainers.image.created": "2024-02-09T15:35:16Z",
        "org.opencontainers.image.revision": "12f63021",
        "org.opencontainers.image.source": "https://github.com/jenkins-infra/docker-confluence-data.git",
        "org.opencontainers.image.url": "\"https://github.com/jenkins-infra/docker-confluence-data.git\""
      },
      "tags": [
        "docker.io/jenkinsciinfra/wiki:latest",
        "docker.io/jenkinsciinfra/wiki:0.1.35"
      ],
      "platforms": [
        "linux/amd64,linux/arm64"
      ]
    }
  }
}

```

</details>

@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 10, 2024

@dduportal
Copy link
Contributor

Do you have an example of the output?

Yes, see above: #834 (comment)

My bad, did not see the comment with the screenshot on phone.

@lemeurherve
Copy link
Member Author

Should be fixed now that yq isn't installed via asdf: jenkins-infra/packer-images#1044

@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 12, 2024

Fixed, result: https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.1.39

Output:

✍ Other changes

📝 Release settings

target:
  default:
    context: /home/jenkins/workspace/bs_docker-confluence-data_0.1.39
    dockerfile: /home/jenkins/workspace/bs_docker-confluence-data_0.1.39/Dockerfile
    args:
      BUILD_DATE: "2024-02-12T18:33:11Z"
      GIT_COMMIT_REV: 435ca69b
      GIT_SCM_URL: https://github.com/jenkins-infra/docker-confluence-data.git
    labels:
      org.label-schema.build-date: "2024-02-12T18:33:11Z"
      org.label-schema.url: '"https://github.com/jenkins-infra/docker-confluence-data.git"'
      org.label-schema.vcs-ref: 435ca69b
      org.label-schema.vcs-url: https://github.com/jenkins-infra/docker-confluence-data.git
      org.opencontainers.image.created: "2024-02-12T18:33:11Z"
      org.opencontainers.image.revision: 435ca69b
      org.opencontainers.image.source: https://github.com/jenkins-infra/docker-confluence-data.git
      org.opencontainers.image.url: '"https://github.com/jenkins-infra/docker-confluence-data.git"'
    tags:
      - docker.io/jenkinsciinfra/wiki:latest
      - docker.io/jenkinsciinfra/wiki:0.1.39
    platforms:
      - linux/amd64,linux/arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants