-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(buildDockerAndPublishImage): annotate GitHub release with make show
output
#834
base: master
Are you sure you want to change the base?
chore(buildDockerAndPublishImage): annotate GitHub release with make show
output
#834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. I did not test it myself locally. @lemeurherve can you confirm that you tested the subset of the script locally?
Yes. |
Do you have an example of the output? |
Yes, see above: #834 (comment) |
Release body content output:
|
yq(1) isn't available at the moment on agents, need to be fixed to use YAML output. Ref: |
My bad, did not see the comment with the screenshot on phone. |
Should be fixed now that |
Fixed, result: https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.1.39 Output:✍ Other changes
📝 Release settingstarget:
default:
context: /home/jenkins/workspace/bs_docker-confluence-data_0.1.39
dockerfile: /home/jenkins/workspace/bs_docker-confluence-data_0.1.39/Dockerfile
args:
BUILD_DATE: "2024-02-12T18:33:11Z"
GIT_COMMIT_REV: 435ca69b
GIT_SCM_URL: https://github.com/jenkins-infra/docker-confluence-data.git
labels:
org.label-schema.build-date: "2024-02-12T18:33:11Z"
org.label-schema.url: '"https://github.com/jenkins-infra/docker-confluence-data.git"'
org.label-schema.vcs-ref: 435ca69b
org.label-schema.vcs-url: https://github.com/jenkins-infra/docker-confluence-data.git
org.opencontainers.image.created: "2024-02-12T18:33:11Z"
org.opencontainers.image.revision: 435ca69b
org.opencontainers.image.source: https://github.com/jenkins-infra/docker-confluence-data.git
org.opencontainers.image.url: '"https://github.com/jenkins-infra/docker-confluence-data.git"'
tags:
- docker.io/jenkinsciinfra/wiki:latest
- docker.io/jenkinsciinfra/wiki:0.1.39
platforms:
- linux/amd64,linux/arm64 |
This PR annotates GitHub release with the output from
make show
allowing to know which target(s) and tag(s) have been published, and which settings have been used for the release.Tested on https://github.com/jenkins-infra/docker-confluence-data/ with success: https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.1.39
Release body content output:
Note: easier to review without whitespace changes, see https://github.com/jenkins-infra/pipeline-library/pull/834/files?diff=unified&w=1
Ref: