added info link for Plugin Health Score

[Harsh3341]

#1320 (comment)

Info links for plugins is been added

[Harsh3341]

Solved #1328

[NotMyFault]

Please don't mark comments as resolved when they are not.

I recommend moving this to a dedicated element because clicking on the question mark links through the plugin page, rather than directly to the health score page, causing unneeded browser noise.

is still to address.

I'd recommend keeping the question mark clickable, additionally to the hover.

[Harsh3341]

I'd recommend keeping the question mark clickable, additionally to the hover.

It is clickable and also can be hovered

[NotMyFault]

I'd recommend keeping the question mark clickable, additionally to the hover.

It is clickable

Why do you think so? You removed the logic for that, after my previous comment, for no reason.

[Harsh3341]

How did you test this? On the preview site clicking the question mark does nothing.

Currently I'm in my phone while clicking on "?" Tooltip is opening, also I have tested this on desktop while clicking and hover

[NotMyFault]

I didn't mention the tooltip, I mentioned the linking action you previously had on the question mark. The need to hover first and click later just requires more action of the user, when there's no need for it.

[Harsh3341]

I didn't mention the tooltip, I mentioned the linking action you previously had on the question mark. The need to hover first and click later just requires more action of the user, when there's no need for it.

O.. I misunderstood what you said before, but now I get it.

What I have done is I have removed link from "?" and added stopPropagation() when clicked on "?" So that it does not redirect to plugin page and also I have removed link because for phone users I want toolkit to open onclick rather then directly redirecting to Health Score page.

What needs to be done is I have to add stopPropagation() in tooltip health score

[NotMyFault]

What I have done is I have removed link from "?" and added stopPropagation() when clicked on "?" So that it does not redirect to plugin page and also I have removed link because for phone users I want toolkit to open onclick rather then directly redirecting to Health Score page.

Yeah, I questioned the "why". This design causes more noise for the end user, especially if the hover is not sticky, if you're not fast quick, you don't make it:

Kapture.2023-04-13.at.09.10.31.mp4

[Harsh3341]

Noted...

With all fixes, I will push the next commit

[Harsh3341]

Yeah, I questioned the "why". This design causes more noise for the end user, especially if the hover is not sticky, if you're not fast quick, you don't make it:

just now checked the code its reactstrap tooltip component causing that issue of hover, tested some changes but still result remains the same, so should I remove the tooltip component and rewrite a different code for it?

[NotMyFault]

Yeah, I questioned the "why". This design causes more noise for the end user, especially if the hover is not sticky, if you're not fast quick, you don't make it:

just now checked the code its reactstrap tooltip component causing that issue of hover, tested some changes but still result remains the same, so should I remove the tooltip component and rewrite a different code for it?

None of that is needed, and out of the scope of the PR. All I asked for is re-adding the ability to click the question mark.

[NotMyFault]

Thanks!

[halkeye]

Suggested change

	value: PropTypes.number,
	value: PropTypes.number.isRequired,

[halkeye]

you don't handle name not being provided, so it should be required

Suggested change

	name: PropTypes.string,
	name: PropTypes.string.isRequired,

[halkeye]

@Harsh3341 do you want to do a followup pr with these? I'm just going to merge.