Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tektoncd pipeline module to 0.32.4 #500

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

ankitm123
Copy link
Contributor

@ankitm123 ankitm123 commented Sep 26, 2022

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

Also upgrades go version to 1.18

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 37.33% // Head: 37.33% // No change to project coverage 👍

Coverage data is based on head (dc4049c) compared to base (44698b2).
Patch has no changes to coverable lines.

❗ Current head dc4049c differs from pull request most recent head bff79ad. Consider uploading reports for the commit bff79ad to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   37.33%   37.33%           
=======================================
  Files          44       44           
  Lines        5944     5944           
=======================================
  Hits         2219     2219           
  Misses       3382     3382           
  Partials      343      343           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ankitm123
Copy link
Contributor Author

/retest

1 similar comment
@ankitm123
Copy link
Contributor Author

/retest

@ankitm123
Copy link
Contributor Author

/retest

Copy link
Contributor

@rajatgupta24 rajatgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitm123
Copy link
Contributor Author

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123, rajatgupta24

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
Copy link
Contributor Author

/hold

Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
@ankitm123
Copy link
Contributor Author

/hold cancel

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ankitm123 ankitm123 merged commit 89593c6 into jenkins-x-plugins:main Sep 29, 2022
@jenkins-x-bot
Copy link
Contributor

@ankitm123: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint bff79ad link /test lint
pr bff79ad link /test pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123
Copy link
Contributor Author

Killed the jobs manually, as they had passed before.

@ankitm123
Copy link
Contributor Author

related to jenkins-x/jx#8283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants