Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade go version to 1.18.4 #176

Merged
merged 1 commit into from
Sep 28, 2022
Merged

refactor: upgrade go version to 1.18.4 #176

merged 1 commit into from
Sep 28, 2022

Conversation

rajatgupta24
Copy link
Member

@rajatgupta24 rajatgupta24 commented Sep 28, 2022 •
edited
Loading

This PR updates the go to 1.18.4

related to: jenkins-x/jx#8283

  • Change the version in go.mod file.
  • Run go mod tidy and ensure that it does not error out.
  • Change GO_VERSION in makefile to the version you are upgrading.
  • Check if there are any references to an older version and replace those.
  • Verify that
    • The build works by running make build.
    • Tests are working, by running make test.
    • Linting checks are working by running make lint.

@rajatgupta24
Copy link
Member Author

/cc ankitm123

@rajatgupta24
Copy link
Member Author 

WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. 
WARN [linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit b2c0e80 into jenkins-x:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitm123 ankitm123 ankitm123 approved these changes

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatgupta24 @jenkins-x-bot @ankitm123