-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create multiarch kubectl image for jx #8412
Conversation
Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
6545931
to
8403d17
Compare
Codecov ReportBase: 34.67% // Head: 34.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8412 +/- ##
=======================================
Coverage 34.67% 34.67%
=======================================
Files 11 11
Lines 1240 1240
=======================================
Hits 430 430
Misses 765 765
Partials 45 45 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajatgupta24, tomhobson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
failed to trigger Pull Request pipeline
|
This would fit better in the jenkins-x-images. It's unnecessary to have to trigger a new build of jx when needing a new kubectl image or vice versa. Now, a problem is that we don't have permissions in that organisation, right? |
Agreed!
Yes, but I have asked James for access. I am not a big fan of having multiple orgs though, it is a pain to keep track of things (and giving access), I preferred the v2 days of having everything in a single org - there used to be repos for builder images. May be we can do that? Alternatively, we can trigger this kubectl image build from github actions manually (from the UI, not particularly interested in this), so that it's not created on every build. |
I think it's easier to have it in a separate repo. But to me it's not necessary that the repo is in jenkins-x-images. |
I will revert this change, and will create a new repo in jx-org today! |
Signed-off-by: ankitm123 ankitmohapatra123@gmail.com
Related to #8411.
Bitnami images don't support ARM yet, and I am not sure when that will land. We can build and maintain our own kubectl image for our usecase. The image is simple to build and smaller as it uses alpine.
https://github.com/jenkins-x/jx3-versions/blob/be23d4f583b765e832a0046e0ffd4f12be3cd21d/charts/external-secrets/kubernetes-external-secrets/values.yaml.gotmpl#L46 -> This is the current image.
Rancher also publishes it's own kubectl image, but we cant use it, as it's based on scratch, and we need base64 decode in the init script: https://github.com/rancher/kubectl/blob/ecb5988682864a252e55600fcca87b6d3d3d4312/Dockerfile#L12