Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify install instructions #8661

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix: simplify install instructions #8661

merged 1 commit into from
Apr 7, 2024

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Apr 6, 2024

The current instructions doesn't work with new versions of cosign. Also the current instructions makes for an unnecessary obstacle for new users. So I think simplifying the instructions makes most sense. I'm adding homebrew instructions while at it.

Possibly https://jenkins-x.io/v3/admin/setup/jx3/ should be complemented with cosign instructions.

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket msvticket requested a review from tomhobson April 6, 2024 12:34
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.62%. Comparing base (762cced) to head (7a7d52b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8661   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files          11       11           
  Lines        1242     1242           
=======================================
  Hits          430      430           
  Misses        767      767           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 551556f into main Apr 7, 2024
10 of 11 checks passed
@jenkins-x-bot jenkins-x-bot deleted the simplifyinstall branch April 7, 2024 19:11
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [8661]: [Method Not Allowed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants