fix: update .golangci.yml for more recent version of linter

[Skisocks]

Linter pipeline has started failing as service.golangci-lint-version is no longer honoured so errors were being returned when trying to run deprecated linters. See linter failing here #8676

This PR removes these deprecations and updates each linters config to the latest versions (finding equivalents if possible). Unused args have also been removed as per revive linter.

[jenkins-x-bot]

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[Skisocks]

/cc @msvticket @tomhobson

[tomhobson]

/ok-to-test

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tomhobson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Skisocks]

/hold

[Skisocks]

/test pr

[Skisocks]

/hold cancel