Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errorf does not support error-wrapping #1487

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix: Errorf does not support error-wrapping #1487

merged 1 commit into from
Sep 28, 2022

Conversation

rajatgupta24
Copy link
Member

@rajatgupta24 rajatgupta24 commented Sep 28, 2022 •
edited
Loading

This Pr also updates the go version to 1.18

related to: jenkins-x/jx#8283

make test error

# github.com/jenkins-x/lighthouse/pkg/plugins_test
./command_test.go:424:5: (*testing.common).Errorf does not support error-wrapping directive %w
FAIL	github.com/jenkins-x/lighthouse/pkg/plugins [build failed]

Replacing %w with %v

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 2db6eb1 into jenkins-x:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitm123 ankitm123 ankitm123 approved these changes

Assignees
No one assigned
Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatgupta24 @jenkins-x-bot @ankitm123