Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split withEnv only on first = character #468

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

Brenne
Copy link
Contributor

@Brenne Brenne commented Jan 5, 2022

This fixes #388 by spliting the withEnv list item only for the first equals sign.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@nre-ableton
Copy link
Contributor

Fix looks ok, but can you provide a test?

@nre-ableton nre-ableton changed the title Fixes #388: withEnv split only first equals Split withEnv only on first = character Jan 10, 2022
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One final small task -- can you please squash together 4cb0d4a and ed41bc8 to a single commit? Also, please remove the link to the issue in the commit message -- the message should just say what is being fixed. Should this repository migrate from GitHub to somewhere else in the future, then the log should still make sense. Thanks!

(Also, I'm happy to do this for you if you'd like, just edit your PR to allow edits from maintainers. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).

@Brenne
Copy link
Contributor Author

Brenne commented Jan 10, 2022

Thank you for the review and feedback. I squashed the commits.
I also allow you to edit my PR, please go ahead and feel free to edit the PR.

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The squashed commit message looks great, thanks!

@nre-ableton nre-ableton merged commit 45841ba into jenkinsci:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion on withEnv fails when Env Var value contains equals (=) sign
2 participants