Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #215 #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlynnWangNewZealand
Copy link

Problem caused by DataSetBuilder.build(). The rowKey which is an instance of TreeSet is sorted by natural ordering.

The values of rowKey seems not visible to end users, got a quick way to fix the issue by adding a prefix to each of them.

Issue#215

Testing done

I have created a class to test this function. Just to save a .png picture to my local.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Problem caused by DataSetBuilder.build(). The `rowKey` which is an instance of
`TreeSet` is sorted by **natural ordering**.

The values of `rowKey` seems not visible to end users, got a quick way to fix
the issue by adding a prefix to each of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant