Bugfix for #215 #337
Merged
Bugfix for #215 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem caused by DataSetBuilder.build(). The `rowKey` which is an instance of `TreeSet` is sorted by **natural ordering**. The values of `rowKey` seems not visible to end users, got a quick way to fix the issue by adding a prefix to each of them.
|
@eroshenkoam What would it take to get this merged in? |
baev
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem caused by DataSetBuilder.build(). The rowKey which is an instance of TreeSet is sorted by natural ordering.
The values of rowKey seems not visible to end users, got a quick way to fix the issue by adding a prefix to each of them.
Issue#215
Testing done
I have created a class to test this function. Just to save a .png picture to my local.
Submitter checklist