Add support for Azure CDN endpoint URL #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked until jenkinsci/azure-storage-plugin#280 is submitted; will need to update Azure Storage plugin version dependency in this PR once that PR is submitted. |
…zure CDN URL changes
|
Tagging maintainer for review @timja. |
timja
reviewed
Dec 13, 2023
src/test/java/com/microsoft/jenkins/artifactmanager/IntegrationTests/IntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/jenkins/artifactmanager/IntegrationTests/IntegrationTest.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Dec 13, 2023
timja
reviewed
Dec 13, 2023
src/test/java/com/microsoft/jenkins/artifactmanager/IntegrationTests/IntegrationTest.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Dec 13, 2023
src/test/java/com/microsoft/jenkins/artifactmanager/IntegrationTests/IntegrationTest.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Dec 13, 2023
src/test/java/com/microsoft/jenkins/artifactmanager/IntegrationTests/IntegrationTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for all your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84
Description
These changes add support for an Azure CDN endpoint URL into the Azure Artifact Manager plugin, which will pull the Azure CDN endpoint URL from the configured Azure Storage Account, if and only if the Azure CDN endpoint URL is configured, and then distribute artifacts in Jenkins using the Azure CDN URL instead of the Azure Storage Account blob URL.
Otherwise, it will use the Azure Storage Account blob URL like normal. This PR is dependent on the upstream changes for the Azure Storage plugin here: jenkinsci/azure-storage-plugin#280
I also fixed some issues I discovered while working on this so that I could get the plugin building locally without issue and to ensure that the Azure Storage and Azure Artifact Manager plugins had the same Jenkins version as a minimum dependency:
Testing done
This change was tested locally in VSCode configured for Java/Jenkins development. I updated the JUnit tests to account for this new feature. I tested this locally using the
mvn verifycommand.Since these changes are dependent on the upstream changes I've made to the Azure Storage plugin, I tested these changes in a local instance of Jenkins using the
mvn hpi:runcommand using a local version of the Azure Storage plugin containing the changes from this PR: jenkinsci/azure-storage-plugin#280.Submitter checklist