Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-36506# Favorite API improvement: inlined favorite items. #322

Merged
merged 1 commit into from
Jul 11, 2016

Conversation

vivek
Copy link
Collaborator

@vivek vivek commented Jul 8, 2016

Related to issue # .

Summary of this pull request:

  • /users/:id/favorites/ response format change. It inlines favorite item. If the item is a branch branch object gets serialized
  • For MBP if master branch is not found returns 400 instead of 500
  • Nested MBP project not fixed yet, see https://issues.jenkins-ci.org/browse/JENKINS-36488.

@imeredith Please review

@cliffmeyers I think I have taken care of all you need for this enhancement, please review.

@reviewbybees

@cliffmeyers
Copy link
Contributor

cliffmeyers commented Jul 8, 2016

@vivek just wanted to confirm that a call to /users/:id/favorites/ will also returned the inlined favorited items for all the user's favorites.

@vivek
Copy link
Collaborator Author

vivek commented Jul 8, 2016

@cliffmeyers yes to get all favorites of a user GET /users/:id/favorites/

@ghost
Copy link

ghost commented Jul 8, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@imeredith
Copy link
Collaborator

🐝 looks ok to me.

@vivek vivek merged commit ddfc185 into master Jul 11, 2016
@vivek vivek deleted the improvement/JENKINS-36506 branch July 11, 2016 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants