Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix/JENKINS-36211] Bind onScroll and handleKeys to this #342

Merged
merged 2 commits into from
Jul 14, 2016

Conversation

scherler
Copy link
Collaborator

@scherler scherler commented Jul 13, 2016

Decription
https://issues.jenkins-ci.org/browse/JENKINS-36639

[hotfix/JENKINS-36211] Bind onScroll and handleKeys to this -> current master throws an exception

The "Scrolling down to the bottom of actively tailing log should reactivate karaoke" had not been implement but I can do that when working on the "jump around" issue

Submitter checklist

  • Change is code complete and matches issue description
  • Apppropriate unit or acceptance tests or explaination to why this change has no tests

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explaination given

@reviewbybees

@ghost
Copy link

ghost commented Jul 13, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@michaelneale
Copy link
Member

Unable to run a multibranch project from the GUI now:

client:

jenkins-js-extension.js:10841 POST http://localhost:8080/jenkins/blue/rest/organizations/jenkins/pipelines/multi3/runs/ 500 (Server Error)run @ jenkins-js-extension.js:10841run @ jenkins-js-extension.js:13884onClick @ jenkins-js-extension.js:13948ReactErrorUtils.invokeGuardedCallback @ blueocean.js:28058executeDispatch @ blueocean.js:20044executeDispatchesInOrder @ blueocean.js:20064executeDispatchesAndRelease @ blueocean.js:19517executeDispatchesAndReleaseTopLevel @ blueocean.js:19528forEachAccumulated @ blueocean.js:34385processEventQueue @ blueocean.js:19690runEventQueueInBatch @ blueocean.js:28084handleTopLevel @ blueocean.js:28095handleTopLevelImpl @ blueocean.js:28173perform @ blueocean.js:33838batchedUpdates @ blueocean.js:27265batchedUpdates @ blueocean.js:31544dispatchEvent @ blueocean.js:28250
jenkins-js-extension.js:13891 Unexpected error queuing a run of "multi3". Response:(anonymous function) @ jenkins-js-extension.js:13891(anonymous function) @ jenkins-js-extension.js:10851
jenkins-js-extension.js:13892 Response {type: "basic", url: "http://localhost:8080/jenkins/blue/rest/organizations/jenkins/pipelines/multi3/runs/", status: 500, ok: false, statusText: "Server Error"…}

server:

[WARNING] Error while serving http://localhost:8080/jenkins/blue/rest/organizations/jenkins/pipelines/multi3/runs/
java.lang.IllegalAccessException: Class org.kohsuke.stapler.Function$InstanceFunction can not access a member of class io.jenkins.blueocean.service.embedded.rest.MultiBranchPipelineImpl$2 with modifiers "public"
    at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:101)
    at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:295)
    at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:287)

@michaelneale
Copy link
Member

🐝 the error is not related to this fix (confirmed)

@scherler scherler merged commit e934206 into master Jul 14, 2016
@scherler scherler deleted the hotfix/JENKINS-36211 branch July 14, 2016 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants