Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init 2.375.1 #1561

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Init 2.375.1 #1561

merged 1 commit into from
Nov 7, 2022

Conversation

NotMyFault
Copy link
Member

No description provided.

@NotMyFault NotMyFault mentioned this pull request Nov 7, 2022
36 tasks
@timja timja added the developer Pull requests that merits a release for plugin developers label Nov 7, 2022
@timja timja enabled auto-merge (squash) November 7, 2022 22:32
@timja timja merged commit 2e3ffce into jenkinsci:master Nov 7, 2022
@NotMyFault NotMyFault deleted the init-2.375.1 branch November 7, 2022 23:23
@jglick
Copy link
Member

jglick commented Nov 14, 2022

@timja @NotMyFault this passed tests when for #1479 we needed to pin gitlab-plugin due to a change made in 2.372 (CC @MarkEWaite). I think the problem was that this should not have been merged at all when it was, because at the time bom-weekly was being tested against 2.371

<jenkins.version>2.371</jenkins.version>
and so the tests being run were that and
<jenkins.version>2.332.4</jenkins.version>
and not
<jenkins.version>2.375</jenkins.version>
at all. Not sure if we can somehow mechanically block an LTS line from being newer than the current weekly, but at least should be called out as a potential trap in the LTS preparation checklist; in other words, #1479 (comment) should have been fixed first.

@MarkEWaite
Copy link
Contributor

Thanks @jglick.

There may be a related issue that needs a fix. The updatecli job on the master branch now expects that a 2.375.1 release exists. The GitHub reported status of the master branch shows that the master branch is failing because updatecli is failing to find the 2.375.1 release. The master branch on ci.jenkins.io is passing, but the updatecli GitHub action is failing.

screencapture-github-jenkinsci-bom-2022-11-14-06_18_55-edit

Will the failing updatecli GitHub action on the master branch prevent a release of a new version of the BOM?

@jglick
Copy link
Member

jglick commented Nov 14, 2022

Or temporarily suppress

lines = [lines[0], lines[-1]] // run PCT only on newest and oldest lines, to save resources
in certain PRs such as LTS prep lines? Could do so in master to block releases which fail in intermediate lines, but this would add a lot of load to ci.jenkins.io. https://github.com/jenkinsci/pipeline-github-plugin#properties could be installed in which case we could check pullRequest.labels, which could also serve to replace

bom/failFast

Line 1 in 3163980

true

@jglick
Copy link
Member

jglick commented Nov 14, 2022

@MarkEWaite you will need to ask someone else to fix updatecli config, since I do not understand any of it.

MarkEWaite added a commit to MarkEWaite/release that referenced this pull request Nov 14, 2022
jenkinsci/bom#1561 (comment)
discusses why we should assure that the bom is already testing the
weekly that will be the baseline of the new LTS before we add a new LTS
to the bom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Pull requests that merits a release for plugin developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants