Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump token-macro from 2.13 to 2.14 in /bom-latest #397

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2021

Bumps token-macro from 2.13 to 2.14.

Commits
  • ab5899c [maven-release-plugin] prepare release token-macro-2.14
  • a9603db Update parboiled to 1.3.x (#70)
  • 2eb270d Bump plugin from 4.14 to 4.15 (#69)
  • 393454a Bump bom-2.222.x from 19 to 20 (#68)
  • ae41ba9 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 7, 2021
@dependabot dependabot bot requested a review from jglick January 7, 2021 05:40
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency org.jenkins-ci.plugins:token-macro:jar:2.14 requires Jenkins 2.274 or higher.

@timja
Copy link
Member

timja commented Jan 7, 2021

Yea nah

@timja timja closed this Jan 7, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/bom-latest/org.jenkins-ci.plugins-token-macro-2.14 branch January 7, 2021 07:41
@jglick
Copy link
Member

jglick commented Jan 7, 2021

Maybe it makes sense to introduce a new bom-trunk artifact that tracks weeklies (or whatever the update cadence might be)? That could help us prepare for the upcoming line. Otherwise the problem is that this PR gets closed and it is not obvious when creating the next line that token-macro needs to be updated, assuming there is no new plugin release.

@timja
Copy link
Member

timja commented Jan 7, 2021

Maybe it makes sense to introduce a new bom-trunk artifact that tracks weeklies (or whatever the update cadence might be)? That could help us prepare for the upcoming line. Otherwise the problem is that this PR gets closed and it is not obvious when creating the next line that token-macro needs to be updated, assuming there is no new plugin release.

possibly, it would be quite hard to tell which versions were available though wouldn't it? (unless you're checking artifactory I guess).

It should be quite easy to just run a dependencies command when we initialise the line?

@jglick
Copy link
Member

jglick commented Jan 7, 2021

hard to tell which versions were available

Well, would mean keeping

<jenkins.version>2.263</jenkins.version>
current. Unfortunately Dependabot will not offer updates on that property as is, I suppose because the dependencyies using this property are inherited and Dependabot does not grok that. Could try adding an explicit (redundant) dep on jenkins-core or jenkins-war or even jenkins-cli or whatever.

run a dependencies command when we initialise the line

That is another option, yes.

Probably more of an issue for this upcoming line than in the typical case, due to all the breaking changes and thus number of plugins using a post-LTS baseline.

@jetersen
Copy link
Member

jetersen commented Jan 7, 2021

Perhaps you can use renovate as it is pretty flexible. You could write a regexManager to update the jenkins.version?

@jglick
Copy link
Member

jglick commented Jan 7, 2021

Prefer not to install another bot if Dependabot can be made to do it.

@jetersen
Copy link
Member

jetersen commented Jan 7, 2021

Perhaps you can trick dependabot by storing the jenkins dependency in a profile? 🤔

@jetersen
Copy link
Member

jetersen commented Jan 7, 2021

@jglick jglick mentioned this pull request Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants