Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66438] replace png with svg icons (ionicons) #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mawinter69
Copy link

@mawinter69 mawinter69 commented May 14, 2023

alternative to #89

refer to ioniocons-api plugin when a suitable symbol is available
Use <l:icon instead of <img
This works for both symbols and images provided by plugins

The difference to #89 is that there the gray color is hard coded. Here I use currentColor so that the actually used color is selected by the theme, that ensures compatibility with other themes.

bumps core to 2.361.4 which requires java11

the symbols in the Cause Column respect the table sizing when only the icon is shown and are shown in one line. Otherwise small icons are used, with each cause on a separate line (see JENKINS-71264)

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

mawinter69 and others added 2 commits May 15, 2023 01:29
alternative to jenkinsci#89

refer to ioniocons-api plugin when a suitable symbol is available
Use <l:icon instead of <img
This works for both symbols and images provided by plugins

bumps core to 2.361.4 which requires java11
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I welcome this change very much! Although the build failed temporarily because the Jenkinsfile modifications aren't trusted, but this shouldn't block a review 🚀

@NotMyFault NotMyFault mentioned this pull request Jul 20, 2023
5 tasks
@mawinter69
Copy link
Author

Now that dark theme plugin made it to the recommended plugins in the installation wizard this PR becomes more urgent as before. The plugin is really giving a bad user experience with dark theme.
@batmat I know you consider this your baby, but I think it is time now that the baby moves forward and doesn't ignore reality.

@cronik
Copy link

cronik commented May 6, 2024

Would love to see this PR merge to align it with latest Jenkins design system. The current icons and tooltips looks weird when used with other updated badges.

Is this plugin up for adoption since there doesn't seem to be any activity in a while?

@cronik
Copy link

cronik commented Jun 21, 2024

Been running a build of this PR in a number of Jenkins instances (2.452.1) for a few weeks. Looks nice in both light and dark themes.

Screenshot 2024-06-21 at 2 58 03 PM
Screenshot 2024-06-21 at 3 09 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants