-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-66438] replace png with svg icons (ionicons) #159
base: master
Are you sure you want to change the base?
Conversation
alternative to jenkinsci#89 refer to ioniocons-api plugin when a suitable symbol is available Use <l:icon instead of <img This works for both symbols and images provided by plugins bumps core to 2.361.4 which requires java11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I welcome this change very much! Although the build failed temporarily because the Jenkinsfile modifications aren't trusted, but this shouldn't block a review 🚀
Now that dark theme plugin made it to the recommended plugins in the installation wizard this PR becomes more urgent as before. The plugin is really giving a bad user experience with dark theme. |
src/main/java/org/jenkinsci/plugins/buildtriggerbadge/IconFinder.java
Outdated
Show resolved
Hide resolved
Would love to see this PR merge to align it with latest Jenkins design system. The current icons and tooltips looks weird when used with other updated badges. Is this plugin up for adoption since there doesn't seem to be any activity in a while? |
alternative to #89
refer to ioniocons-api plugin when a suitable symbol is available
Use <l:icon instead of <img
This works for both symbols and images provided by plugins
The difference to #89 is that there the gray color is hard coded. Here I use currentColor so that the actually used color is selected by the theme, that ensures compatibility with other themes.
bumps core to 2.361.4 which requires java11
the symbols in the Cause Column respect the table sizing when only the icon is shown and are shown in one line. Otherwise small icons are used, with each cause on a separate line (see JENKINS-71264)
Testing done
Submitter checklist