Replace PNG with SVG icons #89
Conversation
NotMyFault
force-pushed
the
feature/master/svg-icons
branch
from
6cba60a
to
6bc0b92
Compare
NotMyFault
force-pushed
the
feature/master/svg-icons
branch
from
988217e
to
acefd06
Compare
|
@batmat Do you mind taking a look over the PR? :) |
NotMyFault
force-pushed
the
feature/master/svg-icons
branch
from
acefd06
to
427b002
Compare
|
Sorry for taking so long. The main reason is that I'm unsure I want this. This plugin is my first Jenkins plugin and kind of my baby you know :). I've done some of these icons myself (ok, they probably don't look awesome, but they were done with love 😁). I see the point on consistency, for sure. But I need to look at these icons to see if I really agree with the replacement. If you don't mind, I would appreciate a side by side comparison of before/after icons. Sorry again for the lag. |
I can understand that for sure :P Some time passed by and the PR description isn't quite up to date anymore. However, when I created the PR initially, the ionicion stuff was still pretty new. Currently, APIs are work in progress that allow plugin developers to utilize the ionicons provided by core in the same way how you can utilize the current icons.
For sure, I'll see if I can attach one tomorrow. |
|
Check the PR description, I added a bunch of screenshots for the current look and the proposed changed, in light and dark mode. |
|
I was about to open a bug report because some icons cannot be seen in dark mode. But this PR already fixed that, and the icons look great! They also go well with the icons design in Jenkins. So yea, vote up! :) |
|
Now with symbols in place we could use the ionicons plugin instead. |
alternative to jenkinsci#89 refer to ioniocons-api plugin when a suitable symbol is available Use <l:icon instead of <img This works for both symbols and images provided by plugins bumps core to 2.361.4 which requires java11
alternative to jenkinsci#89 refer to ioniocons-api plugin when a suitable symbol is available Use <l:icon instead of <img This works for both symbols and images provided by plugins bumps core to 2.361.4 which requires java11
|
Closing in favor of #159 |
This pull request aims to replace existing PNG images with modern SVG ionicons, like they are already used partly in core:
Current look light theme 1/2
Current look light theme 2/2
Current look dark theme 1/2
Current look dark theme 2/2
Proposed change light theme 1/2
Proposed change light theme 2/2
Proposed change dark theme 1/2
Proposed change dark theme 2/2
Also fixes a little typo when overriding icons.