Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage portlet for pull-request-monitoring plugin #195

Merged

Conversation

simonsymhoven
Copy link
Member

@simonsymhoven simonsymhoven commented May 20, 2021

Implement portlet for the https://github.com/jenkinsci/pull-request-monitoring-plugin. The portlet visualize the aggregated results for line, method and instruction coverage of the CoverageResult for the CoverageAction. I used the existing diagram of the CoverageResult as a guideline and implemented the following portlet based on the existing API for the different cases:

Bildschirmfoto 2021-05-26 um 13 34 25

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven marked this pull request as draft May 21, 2021 13:30
@simonsymhoven simonsymhoven mentioned this pull request May 21, 2021
6 tasks
@simonsymhoven
Copy link
Member Author

Due to #182 and failing checks because of Jenkins baseline version (see #196), marked this pr as draft again. Will come back later after finished #182 and extended the change-request coverage api to implement better portlet for pull-request-monitoring plugin.

@uhafner uhafner added the enhancement Enhancement of existing functionality label May 25, 2021
@uhafner uhafner changed the title implement coverage portlet for pull-request-monitoring plugin Add coverage portlet for pull-request-monitoring plugin May 25, 2021
@simonsymhoven simonsymhoven marked this pull request as ready for review May 26, 2021 11:37
@simonsymhoven
Copy link
Member Author

I started to wrap the interfaces into abstract classes. Will come back here and update the pr after jenkinsci/pull-request-monitoring-plugin#75 finished and released.

@uhafner uhafner merged commit b05873c into jenkinsci:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants