-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage portlet for pull-request-monitoring plugin #195
Merged
uhafner
merged 8 commits into
jenkinsci:master
from
simonsymhoven:pull-request-monitoring-portlet
Jun 4, 2021
Merged
Add coverage portlet for pull-request-monitoring plugin #195
uhafner
merged 8 commits into
jenkinsci:master
from
simonsymhoven:pull-request-monitoring-portlet
Jun 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
uhafner
reviewed
May 22, 2021
src/main/java/io/jenkins/plugins/coverage/CoveragePullRequestMonitoringPortlet.java
Outdated
Show resolved
Hide resolved
...ain/resources/io/jenkins/plugins/coverage/CoveragePullRequestMonitoringPortlet/monitor.jelly
Outdated
Show resolved
Hide resolved
uhafner
changed the title
implement coverage portlet for pull-request-monitoring plugin
Add coverage portlet for pull-request-monitoring plugin
May 25, 2021
I started to wrap the interfaces into abstract classes. Will come back here and update the pr after jenkinsci/pull-request-monitoring-plugin#75 finished and released. |
uhafner
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement portlet for the https://github.com/jenkinsci/pull-request-monitoring-plugin. The portlet visualize the aggregated results for line, method and instruction coverage of the CoverageResult for the CoverageAction. I used the existing diagram of the CoverageResult as a guideline and implemented the following portlet based on the existing API for the different cases: