Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore JSR 305 annotations #2238

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Restore JSR 305 annotations #2238

merged 1 commit into from
Mar 23, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 23, 2023 •
edited by jetersen
Loading

Seems I was too aggressive to rip these out in #2234.

Fixes #2236
Fixes #2235
Fixes #2237

CC @timja

@basil basil requested a review from a team as a code owner March 23, 2023 15:42
@basil
Copy link
Member Author

basil commented Mar 23, 2023

I confirmed that WEB-INF/lib/jsr305-3.0.2.jar was present in the last working release, missing in the latest (failing) release, and present with the build from this PR.

@jetersen
Copy link
Member

Oh ya this is needed for nullability reasons 😓

@jetersen jetersen enabled auto-merge (squash) March 23, 2023 16:02
@jetersen jetersen added the bug label Mar 23, 2023
@jetersen jetersen mentioned this pull request Mar 23, 2023
Closed
@jetersen jetersen merged commit be54b44 into jenkinsci:master Mar 23, 2023
@basil basil deleted the jsr305 branch March 23, 2023 16:37
@basil basil mentioned this pull request May 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@basil @jetersen