New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WorkspaceList.tempDir #156

Merged

jglick merged 1 commit into jenkinsci:master from offa:workspace_tempdir

Oct 21, 2021

Contributor

offa commented Oct 19, 2021

Addresses two Todos. WorkspaceList.tempDir() is available with core v1.652 and can replace the handwritten code.

I've added a null-check since tempDir() may return null under some circumstances. However, suggestions are welcome here.

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue


          Use WorkspaceList.tempDir

dc46e87

basil approved these changes

View reviewed changes

jglick added the chore label

jglick merged commit 823faba into jenkinsci:master

offa deleted the workspace_tempdir branch

October 21, 2021 18:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels