Refer to icons using classes instead of filenames #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
approved these changes
Nov 12, 2021
jglick
requested changes
Nov 15, 2021
There was a problem hiding this comment.
Other than the BOM mistake, seems OK in principle, assuming it has been tested and indeed works as expected both on the newly lower baseline and on current weeklies. The icon class change seems right; the baseline version change seems unnecessary, especially given that we are already accommodating current plugin releases in jenkinsci/bom#691.
| @@ -12,7 +12,6 @@ | |||
| xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" | |||
| inkscape:export-ydpi="90" | |||
| inkscape:export-xdpi="90" | |||
| inkscape:export-filename="/Users/stephenc/src/plugins/cloudbees-registration-plugin/src/main/webapp/images/48x48/credentials.png" | |||
zbynek
changed the title
zbynek
changed the title
jglick
approved these changes
Jan 7, 2022
|
CI problem with Artifactory, trying to trigger a fresh build (for some reason the gesture on the Checks tab is not working)… |
If checkout fails then blue ocean replay and checks re-run doesn't work. Needs a build now clicked or this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG icons from core (added in #230 ) can be referenced by class instead of depending on file location in core. That should be more future-proof and seems to be the preferred way.