Fix a small bug in URIRequirementBuilder. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a path is used in the URIRequirementBuilder, it cleared any SchemeRequirement already set. This appears to be a copy-paste error.
|
LGTM, thanks! |
stephenc
added a commit
that referenced
this pull request
Jul 2, 2015
Fix a small bug in URIRequirementBuilder.
|
Created https://issues.jenkins-ci.org/browse/JENKINS-29199. Should I go ahead and close it or wait for the fix to be released? |
|
@ixdy We commonly mark bugs as resolved immediately. I'll update the issue since we cannot ask the bot to annotate the commit now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I found while investigating jenkinsci/ghprb-plugin/issues/117.
When a path is used in the URIRequirementBuilder, it cleared any SchemeRequirement already set.
This appears to be a copy-paste error.