Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add Card views for plugins #50

Merged
merged 4 commits into from
Jun 16, 2020
Merged

Add Card views for plugins #50

merged 4 commits into from
Jun 16, 2020

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Jun 12, 2020 •
edited
Loading

Screenshot from 2020-06-12 17-37-58
This PR adds cards for every plugin. It makes use of the react-strap dependency
You can check it out at /pluginList after you spin up the docker container

@sladyn98 sladyn98 added the frontend Related to the front-end of the service label Jun 12, 2020
@sladyn98 sladyn98 added this to the [GSoC Phase 1] milestone Jun 12, 2020
@sladyn98 sladyn98 requested a review from a team as a code owner June 12, 2020 12:09
@sladyn98 sladyn98 mentioned this pull request Jun 14, 2020
Merged
kwhetstone
kwhetstone approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd make the one change and let's merge. I assume loading the plugin names dynamically will come later.

frontend/src/components/layouts/CardLayout.js Outdated Show resolved Hide resolved
sladyn98 and others added 2 commits June 16, 2020 12:46
@sladyn98 sladyn98 merged commit abb03bd into jenkinsci:master Jun 16, 2020
@sladyn98 sladyn98 mentioned this pull request Jun 19, 2020
Closed
3 tasks
@sladyn98 sladyn98 deleted the 6_plugin_cards branch June 22, 2020 07:53
@sladyn98 sladyn98 added the feature A PR that adds a feature label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwhetstone kwhetstone kwhetstone approved these changes

Assignees
No one assigned
Labels
feature A PR that adds a feature frontend Related to the front-end of the service
Projects
None yet
Milestone
[GSoC Phase 1]
Development

Successfully merging this pull request may close these issues.
2 participants
@sladyn98 @kwhetstone