Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scramble password #6

Merged
merged 2 commits into from
Jun 11, 2012
Merged

Scramble password #6

merged 2 commits into from
Jun 11, 2012

Conversation

ohtake
Copy link
Member

@ohtake ohtake commented Jun 8, 2012

Deploy plugin saves plain passwords into config.xml.
Better to use Scrambler.

These changes are backward-compatible but are not forward-compatible.

@buildhive
Copy link

Jenkins » deploy-plugin #2 SUCCESS
This pull request looks good
(what's this?)

@ohtake
Copy link
Member Author

ohtake commented Jun 10, 2012

ohtake@dd7f823#commitcomment-1437724

this should be x.initCause(e). not x

Fixed and rebased. Thank you.

@buildhive
Copy link

Jenkins » deploy-plugin #3 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Jenkins » deploy-plugin #4 SUCCESS
This pull request looks good
(what's this?)

@ohtake ohtake merged commit 400602b into jenkinsci:master Jun 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants