Allows some default settings to be override using ENV

[xbeta]

Signed-off-by: Sam Xiao sam.xs.xiao@gmail.com

[michaelneale]

@ndeloof WDYT? This is in line with what you were planning? Main concern is the chowning of JENKINS_HOME - if this is bind mounted in - we don't want to do this.

[xbeta]

if we don't use chown on the bind VOLUME, the default plugins will have permission issue.

$ docker run -p 8080:8080 myjenkins
Running from: /usr/share/jenkins/jenkins.war
Oct 01, 2014 9:04:01 PM winstone.Logger logInternal
INFO: Beginning extraction from war file
Oct 01, 2014 9:04:03 PM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: jetty-8.y.z-SNAPSHOT
Oct 01, 2014 9:04:05 PM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: NO JSP Support for , did not find org.apache.jasper.servlet.JspServlet
Jenkins home directory: /var/lib/jenkins found at: EnvVars.masterEnvVars.get("JENKINS_HOME")
Oct 01, 2014 9:04:06 PM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: Started SelectChannelConnector@0.0.0.0:8080
Oct 01, 2014 9:04:06 PM winstone.Logger logInternal
INFO: Winstone Servlet Engine v2.0 running: controlPort=disabled
Oct 01, 2014 9:04:06 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started initialization
Oct 01, 2014 9:04:06 PM hudson.LocalPluginManager loadBundledPlugins
SEVERE: Failed to extract the bundled plugin mailer.hpi
java.io.FileNotFoundException: /var/lib/jenkins/plugins/mailer.jpi (Permission denied)

[xbeta]

@ndeloof will use this as a base image for building custom jenkins image

[ndeloof]

@xbeta yes, I understood well the use case (and have a comparable one), just would like to only include a subset. Give me some time to review in detail

[xbeta]

@ndeloof Thx! But after you merge #16 to upstream, we cannot use jenkins.sh anymore to take care of ${JENKINS_HOME}/plugins and such. I'm OK with that, but let me know what you think we can do in combine. I had spent probably 3~4 hrs today just to rebase several changes and would really don't want to do that again if not needed. Hope you can understand that.

[ndeloof]

This is by intention. customizing plugins should not occur when running the image but at build time. The entrypoint command should not have to do any post-processing on image to complete the installation.

Understand how annoying is to rebase changes. Don't spend to much time doing this, I can cherry-pick your commits - for this reason I'd prefer you make some baby steps changes as individual commits, so it's simpler to review them.

[xbeta]

@ndeloof sure, let me know what works best for you. I agree the point that we should keep the customizing plugins on the custom image build at build time.

Not sure how you want me to separate them into smaller commits, but I can take a look at that later tomorrow.

[ndeloof]

b32f552 introduced JENKINS_OPTS that mostly cover this request

[xbeta]

@ndeloof What about $JENKINS_HOME ? I would much prefer to leave it in /var/lib/jenkins as default Ubuntu installation.

also $JENKINS_MAXOPENFILES

[ndeloof]

@xbeta open separate issues to discuss those if you wish

[xbeta]

@ndeloof open it in #23