[BUG] build do not fail when cleaning up but there is no lock files

[Aigrefin]

Hello there,

The build fails when there is no plugins, because install-plugins.sh tries to rm lock files without -f.
This commit adds the -f option to the rm of "Cleaning up locks", allowing the script to finish gracefully.

Happy Hacktoberfest !

[oleg-nenashev]

I would rather explicitly check the file existence. Otherwise it may suppress some valid cases (e.g. locked file on NFS, etc.)

[Aigrefin]

Hello,
This will check for lock files existence and remove them without force.

[oleg-nenashev]

👍

[oleg-nenashev]

@carlossg wdyt?

[carlossg]

Not sure if it makes a difference but I would use

find "$REF_DIR" -iname "*.lock" -exec rm -r "{}" \;

[Aigrefin]

@carlossg When I run find "$REF_DIR" -iname "*.lock" -exec rm -r "{}" \;, for some reasons I don't really get, it fails on bats tests :

     Installed plugins:
     ant:1.3
     credentials:2.1.16
     display-url-api:2.1.0
     filesystem_scm:1.21-alpha-1
     git-client:2.5.0
     git:3.6.3
     javadoc:1.4
     junit:1.21
     mailer:1.20
     matrix-project:1.12
     maven-plugin:2.7.1
     mesos:0.13.0
     scm-api:2.2.3
     script-security:1.34
     ssh-credentials:1.13
     structs:1.10
     workflow-scm-step:2.6
     workflow-step-api:2.13
     Cleaning up locks
     find: ‘/usr/share/jenkins/ref/plugins/mailer.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/script-security.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/javadoc.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/git-client.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/matrix-project.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/credentials.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/ant.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/junit.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/ssh-credentials.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/workflow-scm-step.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/maven-plugin.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/workflow-step-api.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/scm-api.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/git.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/display-url-api.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/mesos.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/structs.lock’: No such file or directory
     find: ‘/usr/share/jenkins/ref/plugins/filesystem_scm.lock’: No such file or directory
     The command '/bin/sh -c /usr/local/bin/install-plugins.sh maven-plugin:2.7.1 ant:1.3 mesos:0.13.0 git:latest filesystem_scm:experimental' returned a non-zero code: 1
   --
   
 ✓ clean work directory
 ✓ build image
 ✓ clean test containers
 ✓ test multiple JENKINS_OPTS
 ✓ test jenkins arguments
 ✓ create test container
 ✓ test container is running
 ✓ Jenkins is initialized
 ✓ JAVA_OPTS are set
 ✓ clean test containers

20 tests, 4 failures

Any idea ?

[carlossg]

Needs the -prune option

find "$REF_DIR" -iname "*.lock" -prune -exec rm -r "{}/" \;

[batmat]

@Aigrefin did you try Carlos proposal?

[batmat]

LGTM, will merge when I see a green PR build.

[batmat]

https://ci.jenkins.io/job/Packaging/job/docker/job/PR-587/2055/console succeeded, but for some reason there's a credentials issue apparently going on to report the status back:

Merging.