Try to do the Docker build in CI

[jglick]

Trying to restore Docker builds lost after 17cac5e. Wondered whether the build is actually working for anyone else, since locally I am getting

Step 5/6 : RUN go get -d -v golang.org/x/sys/unix
 ---> Running in 6ba45fbb6c16
Fetching https://golang.org/x/sys/unix?go-get=1
https fetch failed: Get https://golang.org/x/sys/unix?go-get=1: dial tcp: lookup golang.org on 192.168.86.1:53: read udp 172.17.0.3:58597->192.168.86.1:53: i/o timeout
package golang.org/x/sys/unix: unrecognized import path "golang.org/x/sys/unix" (https fetch: Get https://golang.org/x/sys/unix?go-get=1: dial tcp: lookup golang.org on 192.168.86.1:53: read udp 172.17.0.3:58597->192.168.86.1:53: i/o timeout)
The command '/bin/sh -c go get -d -v golang.org/x/sys/unix' returned a non-zero code: 1
Command execution failed.

Perhaps it would be better to move the Go sources to another repo, say with Docker automatic builds, and consume them in this repo as a binary.

[jglick]

Trying to follow the decisions in #106 & #121. If Docker is not working but we are in CI (typically because we are running in Windows), native image generation will be skipped…as will this whole test:

durable-task-plugin/src/test/java/org/jenkinsci/plugins/durabletask/BourneShellScriptTest.java

Line 112 in 6b6a88e

assumeTrue("Docker is available", new Docker().isAvailable());

[jglick]

On maven-windows:

 [INFO] Running org.jenkinsci.plugins.durabletask.BourneShellScriptTest
 [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.011 s - in org.jenkinsci.plugins.durabletask.BourneShellScriptTest

As expected?

[jglick]

And mostly passing now on Linux, with just a couple skips, though BourneShellScriptTest is really slow.

[jglick]

Hmm, Docker build is passing in CI:

 Step 5/6 : RUN go get -d -v golang.org/x/sys/unix
  ---> Running in 8a1ec60ef70f
 Fetching https://golang.org/x/sys/unix?go-get=1
 Parsing meta tags from https://golang.org/x/sys/unix?go-get=1 (status code 200)
 get "golang.org/x/sys/unix": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at https://golang.org/x/sys/unix?go-get=1
 get "golang.org/x/sys/unix": verifying non-authoritative meta tag
 Fetching https://golang.org/x/sys?go-get=1
 Parsing meta tags from https://golang.org/x/sys?go-get=1 (status code 200)
 golang.org/x/sys (download)

So I wonder what is going on with my machine (Ubuntu):

$ docker -v
Docker version 19.03.8, build afacb8b7f0

[jglick]

Now seems to be broken on Windows because we cannot even run shell scripts at all.

[jglick]

Local failure was due to some sort of networking problem in Docker, since resolved.

[car-roll]

Perhaps it would be better to move the Go sources to another repo, say with Docker automatic builds, and consume them in this repo as a binary.

That is definitely the plan moving forward!

And mostly passing now on Linux, with just a couple skips, though BourneShellScriptTest is really slow.

It definitely is a beast. I'm not sure if the parameterized tests are overkill, but given all the different environments that it runs on and how any little change could affect some environment, maybe it's for the best?

[jglick]

maybe it's for the best?

Yeah I would not advocate reducing test coverage, this is critical, just wondering if there is some obvious inefficiency here.

[car-roll]

closing, since docker builds have now been moved to lib-durable-task