Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15 Fix test connections (avoid conflict credentialsId with ssh creds) #72

Merged
merged 1 commit into from
May 21, 2019
Merged

#15 Fix test connections (avoid conflict credentialsId with ssh creds) #72

merged 1 commit into from
May 21, 2019

Conversation

terma
Copy link

@terma terma commented May 18, 2019 •
edited
Loading

Why?

EC2FleetCloud is using field credentialsId which conflicts on Jenkins UI with similar field from computerConnector as result Jenkins pass to server side for test connection or other operations value from incorrect credentialsId

Fix

As we cannot rename var from computerConnector rename our from credentialsId to awsCredentialsId but keep both for back compatibility.

@terma
Copy link
Author

terma commented May 20, 2019

JENKINS-35435

@terma terma merged commit 5a30180 into master May 21, 2019
@terma terma deleted the fix-test-connection branch May 21, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@terma