-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for customized subject, status and color #31
Conversation
- fixed README.md
- fixed dependencies
- improved documentation
- added badge handler for creation of custom job- or run-less badges
- added handling for custom parameters - prepare next major release
- added ExtensionPoints for selecting `job`, `build` and parameters (`subject`, `status`, `color`, `animatedOverlayColor`)
</dependency> | ||
<dependency> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>cobertura</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's added as hard dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's mistake adding hard dependency for such plugin on workflow and cobertura
Adding a hard dep on Pipeline Step API is OK, it does not require Pupeline: Job or other user-facing plugins to nbe installed. Cobertura is a problem, yes |
flat-square
.