Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for customized subject, status and color #31

Merged
merged 21 commits into from
Dec 10, 2018
Merged

Added support for customized subject, status and color #31

merged 21 commits into from
Dec 10, 2018

Conversation

thomas-dee
Copy link
Contributor

</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>cobertura</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's added as hard dependency?

Copy link
Member

@KostyaSha KostyaSha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's mistake adding hard dependency for such plugin on workflow and cobertura

@KostyaSha
Copy link
Member

CC @daniel-beck @oleg-nenashev

@oleg-nenashev
Copy link
Member

Adding a hard dep on Pipeline Step API is OK, it does not require Pupeline: Job or other user-facing plugins to nbe installed.

Cobertura is a problem, yes

@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants