[JENKINS-45055] Fix all spotbugs #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm kinda stumped that this broke a test and because my machine refuses to run the tests I'm pretty much stuck |
|
Apparently the older version of script security just doesn't run right on my system and updating made the test run :/ |
res0nance
commented
Oct 7, 2019
| @CheckForNull | ||
| private final String scriptFilePath; | ||
| @CheckForNull | ||
| private final String scriptContent; | ||
| @CheckForNull | ||
| @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "EnvInjectEvaluatedGroovyScriptTest#testWorkaroundSecurity86 relies on the serialization of this object") |
There was a problem hiding this comment.
I'm not sure why we can't serialize this bit without Spotbugs complaining
| @@ -49,7 +49,7 @@ public Environment setUp(AbstractBuild build, Launcher launcher, BuildListener l | |||
| public static final class DescriptorImpl extends BuildWrapperDescriptor { | |||
| @Override | |||
| public String getDisplayName() { | |||
| return null; | |||
| return "SetEnvBuildWrapper"; | |||
There was a problem hiding this comment.
If you put a name, these wrappers will start appearing in the lists IIRC
There was a problem hiding this comment.
Hmm i guess i could set it to a blank name so spotbugs wont complain, would that be ok?
added 2 commits
October 8, 2019 14:48
|
Encoding and display name changes may cause regressions. I still need to review it carefully, not including into the today;s release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all remaining spotbugs in envinject