check if commit author is blacklisted before checking if they are whitelisted #830
+26
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorfr
force-pushed
the
avoid-404
branch
2 times, most recently
from
05585f3
to
5107187
Compare
|
@jenkinsci/ghprb-plugin-developers any chance you can take a look? hope the approach makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is an implementation proposal to prevent cases like #831 by adding known users to the list of committers to skip (introduced in #488).
if the PR author is in the deny list, they will never be checked for org membership.
this will prevent the api call that returns 404 and will prevent rate limit.
internal reference: https://issues.redhat.com/browse/APPSRE-4423