[JENKINS-46929] Limit number of projects added to response headers #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Sep 22, 2017
| @@ -609,6 +614,7 @@ public String getShortDescription() { | |||
| } | |||
|
|
|||
| private static final Logger LOGGER = Logger.getLogger(GitStatus.class.getName()); | |||
| private static final int MAX_REPORTED_CONTRIBUTORS = 10; | |||
There was a problem hiding this comment.
I made the limit 10 arbitrarily. Does anyone have a strong opinion on a different limit? Also, does anyone see value in allowing the limit to be set via environment variable, so that anything relying on the urls in the headers could set it as a workaround?
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
MarkEWaite
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-46929
I changed
GitStatus#doNotifyCommitto only add up to 10 "Triggered" headers (which contain URLs to downstream projects for which polling or builds have been scheduled by this commit) to its response. This should preventjava.io.IOException: Response header too largeexceptions when a repository is used in a large number of projects.@reviewbybees