Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for log suppression #138

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Conversation

mrginglymus
Copy link
Contributor

I think this is all the necessary boilerplate required? Will update docs as well, ofc.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #138 (a8ea758) into master (800e395) will decrease coverage by 1.17%.
The diff coverage is 12.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
- Coverage     82.11%   80.93%   -1.18%     
  Complexity      158      158              
============================================
  Files            13       13              
  Lines           464      472       +8     
  Branches         45       45              
============================================
+ Hits            381      382       +1     
- Misses           62       69       +7     
  Partials         21       21              
Impacted Files Coverage Δ Complexity Δ
...ithub/status/GitHubStatusChecksConfigurations.java 80.00% <0.00%> (-20.00%) 0.00 <0.00> (ø)
...cks/github/status/GitSCMStatusChecksExtension.java 72.72% <0.00%> (-11.49%) 7.00 <0.00> (ø)
...ithub/status/GitHubSCMSourceStatusChecksTrait.java 71.87% <25.00%> (-6.70%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800e395...8934c06. Read the comment docs.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would be a good addition

pom.xml Outdated Show resolved Hide resolved
@@ -13,4 +13,8 @@
<f:checkbox/>
</f:entry>

<f:entry title="Suppress log output in checks" field="suppressLogs">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding help-suppressLogs.html to this folder

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any other docs updates needed in readme or elsewhere?

@XiongKezhi XiongKezhi linked an issue Mar 12, 2021 that may be closed by this pull request
@XiongKezhi
Copy link
Contributor

any other docs updates needed in readme or elsewhere?

I'll update the readme with a new screenshot and explains the status checks properties.

@XiongKezhi XiongKezhi merged commit 1934792 into jenkinsci:master Mar 13, 2021
@timja timja added the enhancement New feature or request label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Checks containing a lot of logs/data are not sent to GitHub
5 participants