Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove condition preventing github enterprise instances being returned #31

Merged
merged 1 commit into from
Jun 8, 2014

Conversation

evilmilo
Copy link
Contributor

Ensure github-plugin can auto register hooks with enterprise git, remove the condition
which only fetched GitHub instances where the site was official github site, otherwise
returned empty collection

the condition which only fetched GitHub instances where the site was
official github site, otherwise returned empty collection
@buildhive
Copy link

Jenkins » github-plugin #51 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@elordahl
Copy link
Contributor

I just made a pull request with the exact same code. Glad to see i'm not alone---I'll cancel my pull request, and ensure to check existing pull requests first :)

Any plans to pull this in?

@jprosevear
Copy link

I think we are in you-should-just-ask-for-commit-access territory. Unfortunately the buildhive build is no longer available for testing.

@jglick
Copy link
Member

jglick commented Jan 6, 2014

@jprosevear moved to jenkins.ci.cloudbees.com.

@jprosevear
Copy link

@jglick these PRs are too old to have a cached build afaict. This:
https://jenkins.ci.cloudbees.com/job/plugins/job/github-plugin/20/

Is the oldest build available.

@jglick
Copy link
Member

jglick commented Jan 6, 2014

Right; not sure if pushing a new commit to this PR (e.g., git merge master) would suffice to trigger a PR build, or if only newly filed PRs would get built.

@oleg-nenashev
Copy link
Member

Commented the new PR (#37).
What PR should we close to remove the duplication?

@jprosevear
Copy link

Close #37 - I only opened it to trigger a new build.

@kohsuke
Copy link
Member

kohsuke commented Jun 8, 2014

Closed #37. I investigated the security concern from @oleg-nenashev in that PR, and I think it is safe.

@kohsuke kohsuke merged commit d41be07 into jenkinsci:master Jun 8, 2014
kohsuke added a commit that referenced this pull request Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants