-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove condition preventing github enterprise instances being returned #31
Conversation
the condition which only fetched GitHub instances where the site was official github site, otherwise returned empty collection
Jenkins » github-plugin #51 SUCCESS |
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
I just made a pull request with the exact same code. Glad to see i'm not alone---I'll cancel my pull request, and ensure to check existing pull requests first :) Any plans to pull this in? |
I think we are in you-should-just-ask-for-commit-access territory. Unfortunately the buildhive build is no longer available for testing. |
@jprosevear moved to jenkins.ci.cloudbees.com. |
@jglick these PRs are too old to have a cached build afaict. This: Is the oldest build available. |
Right; not sure if pushing a new commit to this PR (e.g., |
Commented the new PR (#37). |
Close #37 - I only opened it to trigger a new build. |
Closed #37. I investigated the security concern from @oleg-nenashev in that PR, and I think it is safe. |
Ensure github-plugin can auto register hooks with enterprise git, remove the condition
which only fetched GitHub instances where the site was official github site, otherwise
returned empty collection