Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab repository browser breaks Freestyle job configuration #138

Closed
MarkEWaite opened this issue Apr 25, 2021 · 0 comments · Fixed by #139
Closed

GitLab repository browser breaks Freestyle job configuration #138

MarkEWaite opened this issue Apr 25, 2021 · 0 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Apr 25, 2021 •
edited
Loading

Version report

Jenkins and plugins versions report:

Click to expand! 
Jenkins: 2.289
OS: Linux - 4.15.0-142-generic
---
gitlab-branch-source:1.5.7
gitlab-plugin:1.5.20

ace-editor:1.1
adoptopenjdk:1.4
analysis-model-api:10.0.0
ant:1.11
antisamy-markup-formatter:2.1
apache-httpcomponents-client-4-api:4.5.13-1.0
async-http-client:1.9.40.0
authentication-tokens:1.4
authorize-project:1.4.0
badge:1.8
basic-branch-build-strategies:1.3.2
bitbucket:1.1.27
blueocean-autofavorite:1.2.4
blueocean-bitbucket-pipeline:1.24.6
blueocean-commons:1.24.6
blueocean-config:1.24.6
blueocean-core-js:1.24.6
blueocean-dashboard:1.24.6
blueocean-display-url:2.4.1
blueocean-events:1.24.6
blueocean-git-pipeline:1.24.6
blueocean-github-pipeline:1.24.6
blueocean-i18n:1.24.6
blueocean-jwt:1.24.6
blueocean-personalization:1.24.6
blueocean-pipeline-api-impl:1.24.6
blueocean-pipeline-editor:1.24.6
blueocean-pipeline-scm-api:1.24.6
blueocean-rest-impl:1.24.6
blueocean-rest:1.24.6
blueocean-web:1.24.6
blueocean:1.24.6
bootstrap4-api:4.6.0-3
bouncycastle-api:2.20
branch-api:2.6.3
build-blocker-plugin:1.7.7
build-name-setter:2.2.0
build-timeout:1.20
buildresult-trigger:0.17
checks-api:1.7.0
cloudbees-bitbucket-branch-source:2.9.8
cloudbees-folder:6.15
cloudbees-jenkins-advisor:3.2.5
code-coverage-api:1.3.2
command-launcher:1.5
conditional-buildstep:1.4.1
config-file-provider:3.8.0
configuration-as-code:1.47
configurationslicing:1.52
copyartifact:1.46
credentials-binding:1.24
credentials:2.3.18
data-tables-api:1.10.23-3
description-setter:1.10
display-url-api:2.3.4
docker-commons:1.17
docker-workflow:1.26
dtkit-api:3.0.0
durable-task:1.35
echarts-api:5.1.0-2
elastic-axis:1.3
email-ext:2.82
envinject-api:1.7
envinject:2.4.0
external-monitor-job:1.7
favorite:2.3.3
font-awesome-api:5.15.2-2
forensics-api:1.0.0
git-client:3.7.2-rc2794.85c827b258f0
git-forensics:1.0.0
git-parameter:0.9.13
git-server:1.9
git-userContent:1.4
git:4.7.2-rc4325.76725ac7d380
gitea:1.2.1
github-api:1.222
github-branch-source:2.10.2
github-scm-filter-aged-refs:0.2.0
github-scm-trait-commit-skip:0.4.0
github:1.33.1
gitlab-api:1.0.6
groovy-postbuild:2.5
h2-api:1.4.199
handlebars:3.0.8
handy-uri-templates-2-api:2.1.8-1.0
htmlpublisher:1.25
implied-labels:0.7
jackson2-api:2.12.3
jacoco:3.1.2-SNAPSHOT (private-b3d6940e-mwaite)
javadoc:1.6
jaxb:2.3.0.1
jdk-tool:1.5
jenkins-design-language:1.24.6
jira:3.2.1
jjwt-api:0.11.2-9.c8b45b8bb173
jmh-report:0.9.1-SNAPSHOT (private-688739fd-RishabhBudhouliya)
job-dsl:1.77
jquery-detached:1.2.1
jquery3-api:3.6.0-1
jquery:1.12.4-1
jsch:0.1.55.2
junit-attachments:1.6
junit-realtime-test-reporter:0.6
junit:1.49
label-verifier:1.4
ldap:2.6
leastload:3.0.0
locale:1.4
lockable-resources:2.10
log-parser:2.1
mailer:1.34
mapdb-api:1.0.9.0
matrix-auth:2.6.6
matrix-project:1.18
maven-plugin:3.10
mercurial:2.14
metrics:4.0.2.7
momentjs:1.1.1
monitoring:1.87.0
naginator:1.18.1
nodelabelparameter:1.8.0
okhttp-api:3.14.9
oracle-cloud-infrastructure-compute:1.0.14
pam-auth:1.6
parallel-test-executor:1.13
parameterized-trigger:2.40
pipeline-build-step:2.13
pipeline-github-lib:1.0
pipeline-graph-analysis:1.10
pipeline-graph-view:0.1
pipeline-input-step:2.12
pipeline-maven:3.10.0
pipeline-milestone-step:1.3.2
pipeline-model-api:1.8.4
pipeline-model-definition:1.8.4
pipeline-model-extensions:1.8.4
pipeline-rest-api:2.19
pipeline-stage-step:2.5
pipeline-stage-tags-metadata:1.8.4
pipeline-stage-view:2.19
pipeline-utility-steps:2.7.1
plain-credentials:1.7
platformlabeler:820.ve11757883dbc
plugin-util-api:2.1.0
pollscm:1.3.1
popper-api:1.16.1-2
preSCMbuildstep:0.3
promoted-builds:3.9.1
pubsub-light:1.13
resource-disposer:0.15
run-condition:1.5
scm-api:2.6.4
script-security:1.76
snakeyaml-api:1.27.0
sse-gateway:1.24
ssh-agent:1.22
ssh-credentials:1.18.2
ssh-slaves:1.31.7
sshd:3.0.3
structs:1.22
support-core:2.73
swarm:3.25
text-finder:1.15
throttle-concurrents:2.2
timestamper:1.12
token-macro:2.15
trilead-api:1.0.13
variant:1.4
versioncolumn:2.1
view-job-filters:2.3
warnings-ng:9.0.1
windows-slaves:1.7
workflow-aggregator:2.6
workflow-api:2.42
workflow-basic-steps:2.23
workflow-cps-global-lib:2.19-SNAPSHOT (private-ab276be9-mwaite)
workflow-cps:2.90
workflow-durable-task-step:2.38
workflow-job:2.40
workflow-multibranch:2.23
workflow-scm-step:2.13-rc374.dcd7e780273e
workflow-step-api:2.23
workflow-support:3.8
ws-cleanup:0.39
xshell:0.10
xunit:3.0.2

What Operating System are you using (both controller, and any agents involved in the problem)?

Controller: Jenkins image jenkins/jenkins:2.289 running on a Ubuntu 20.04 operating system
OS: Linux - 4.15.0-142-generic

Reproduction steps

  1. Define a Jenkins freestyle project with git as the SCM
  2. In the "Repository browser" section of the job definition, change the definition from the default '(Auto)' to 'GitLab'
  3. Save the freestyle project
  4. Attempt to configure the freestyle project again and notice that the "Save" button is no longer available on the page. A stack trace is reported to the Jenkins log that:
listScmBrowsers.jelly:43:77: <st:include> No page found 'config.jelly' for 
class io.jenkins.plugins.gitlabbranchsource.helpers.GitLabBrowser$DescriptorImpl

Results

Expected result:

  • Able to reconfigure and save freestyle job that configures the 'GitLab' repository browser

Actual result:

  • Freestyle job configured with 'GitLab' repository browser cannot be configured

Workaround:

  • Use the 'gitlab' repository browser in the freestyle project instead of using the 'GitLab' repository browser
@MarkEWaite MarkEWaite added the bug Something isn't working label Apr 25, 2021
MarkEWaite added a commit to MarkEWaite/.github that referenced this issue Apr 25, 2021
@MarkEWaite
Use an expandable details section for version info report
d65af2c 
Make it easier for those reading the bug report to see the reproduction
steps without scrolling.

See jenkinsci/gitlab-branch-source-plugin#138
for a working example
@MarkEWaite MarkEWaite mentioned this issue Apr 25, 2021
Closed
6 tasks
MarkEWaite added a commit to MarkEWaite/gitlab-branch-source-plugin that referenced this issue Apr 26, 2021
@MarkEWaite
Fix jenkinsci#138 - Repository browser break freestyle project save
00d4990 
Move the existing config.jelly file into the location where it will be
found by Jenkins.  Allows the "GitLab" repository browser to be used
from Freestyle projects as intended.

Also adds top level help for the GitLab repository browser so that it
can be found in the Pipeline Steps reference for the GitLabBrowser.

Not yet ready to add an `@Symbol` annotation because this repository
browser 'GitLab' differs only by case from the similar repository browser
inside the git plugin (called 'gitlab').
@MarkEWaite MarkEWaite mentioned this issue Apr 26, 2021
Merged
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this issue Apr 26, 2021
@MarkEWaite
Use gitlab branch source plugin 1.5.8-rc603.00d49908fe3c
885a281 
Fixes jenkinsci/gitlab-branch-source-plugin#138

Freestyle job configuration will not display and will not save if the
"GitLab" repository browser is enabled.  Stack trace in the Jenkins
log reports that the config.jelly file is not found in the expected
location.
markjacksonfishing pushed a commit that referenced this issue May 10, 2021
@MarkEWaite
Fix #138 - Repository browser break freestyle project save (#139)
b241f01 
Move the existing config.jelly file into the location where it will be
found by Jenkins.  Allows the "GitLab" repository browser to be used
from Freestyle projects as intended.

Also adds top level help for the GitLab repository browser so that it
can be found in the Pipeline Steps reference for the GitLabBrowser.

Not yet ready to add an `@Symbol` annotation because this repository
browser 'GitLab' differs only by case from the similar repository browser
inside the git plugin (called 'gitlab').
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this issue May 10, 2021
@MarkEWaite
Use gitlab branch source plugin 1.5.8-rc603.b241f0132403
7035bea 
GitLab repository browser can now be selected from a Freestyle job
configuration without breaking the job definition.

Fixes jenkinsci/gitlab-branch-source-plugin#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #138 - Repository browser break freestyle project save MarkEWaite/gitlab-branch-source-plugin
1 participant
@MarkEWaite