[JENKINS-58666, JENKINS-58730] Feature/trusted contributors #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjacksonfishing
approved these changes
Jul 26, 2019
baymac
added
the
Do Not Merge
jetersen
requested changes
Jul 29, 2019
There was a problem hiding this comment.
Missing getTrustedRevision in scmSource
See example: https://github.com/search?q=getTrustedRevision+org%3Ajenkinsci&type=Code
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSourceRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
Show resolved
Hide resolved
baymac
force-pushed
the
feature/trusted-contributors
branch
from
fe1a722
to
eb01073
Compare
|
This PR is ready to be merged. The trusted member strategy works now. Thanks @Casz for helping me fix this. Thanks @oleg-nenashev for suggesting this feature. This one way we can say Jenkins is better than GitLab CI. Because GitLab CI doesn't have any implementation for run pipeline on forked projects MR. |
baymac
removed
the
Do Not Merge
markjacksonfishing
approved these changes
Jul 30, 2019
jetersen
reviewed
Jul 30, 2019
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSourceRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSourceRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSourceRequest.java
Outdated
Show resolved
Hide resolved
baymac
changed the title
|
Btw @Casz we need to figure out what's wrong with web hook. This is the single most important feature we need before making the beta release. |
baymac
force-pushed
the
feature/trusted-contributors
branch
from
1aee0fd
to
9ea7ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @oleg-nenashev suggestion added the trusted contributors (or members) permission for Fork Merge Requests Trait. The current implementation of permission in
GitLabSCMSourceRequestworks, as is correctly logged withmr authorand it's corresponding permission before the MR indexing. But theForkMergeRequestTraitdoesn't work in itself. Tried with different trust likemember,nobodyetc. It doesn't work for any case. So there must be some problem in our implementation of ForkMRTrait.