Feat/add corporate proxy support #124
Conversation
|
Hello, Thanks for approving this PR. Just to now, when do you plan to merge and to release it ? Thanks |
| } | ||
| throw new IllegalStateException( | ||
| String.format("No server found with the name: %s", serverName)); | ||
| } | ||
|
|
||
| public static Map<String, Object> getProxyConfig () { |
There was a problem hiding this comment.
I think we could support https proxy settings..But i'm not sure
There was a problem hiding this comment.
It's a good point. In Jenkins plugin manager proxy configuration, serverUrl does not include protocol (http or https), and there is no field to specify the protocol to use.
Based on this configuration, we are not able to determine if it is http or https protocol. We could presume that if it is 80, use HTTP and 443 use HTTPS, but proxy port can still be 8443 or something else.
I think if we want to support both http and https, this plugin must have it's own proxy user settings and proxy support implementation.
There was a problem hiding this comment.
Hello, is it good for you ?
There was a problem hiding this comment.
It is. I wish I would have write access here..meh
|
Hello, do you have any update about who can merge this PR ? |
We've ran into this issue when issuing a scan. Any idea of when this will be released? |
I propose this PR in response of the following issue : https://issues.jenkins.io/browse/JENKINS-62779
The point is to support corporate proxy. Before calling GitlabApi, we retrieve proxy parameters from Plugin Manager configuration.
My code is based on gitlab4j-api proxy implementation.
Unfortunately, ProxyClientConfig does not support no_proxy parameter. At least, there is few chance to have multiple gitlab servers behind proxy and directly reachable.
About test : I didn't add any... but no tests have been broken. I did test the configuration on my Jenkins with this new version :
I do not have any environment to test with authenticated proxy.
Finally, feel free to propose any improvments, I'm kind of new here :)