Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG icons with SVGs #174

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

NotMyFault
Copy link
Member

The change proposed exchanges the PNG icons with SVG icons, to integrate better with the modern appearance of Jenkins:

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault
Copy link
Member Author

Heyo @LinuxSuRen,
do you mind taking a look? Would be nice to have this one available as well on the next LTS, which focuses a lot on UI improvements.
Thanks in advance!

@jetersen
Copy link
Member

@NotMyFault should the jenkins version be bumped?

@NotMyFault
Copy link
Member Author

@NotMyFault should the jenkins version be bumped?

If you want to, though this works even on an older baseline.

@jetersen
Copy link
Member

Thanks @NotMyFault all I wanted to know 😄

@jetersen jetersen merged commit f7bd7b3 into jenkinsci:master Apr 15, 2022
@NotMyFault NotMyFault deleted the feat/master/icons branch April 15, 2022 15:27
@jetersen jetersen added the enhancement New feature or request label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants