Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong action IDs in GitLabMergeRequestTrigger.java and add support to "approved" and "unapproved" as well #252

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

mifitous
Copy link
Contributor

modified according to official documentation: https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mifitous
Copy link
Contributor Author

@mifitous mifitous changed the title Update GitLabMergeRequestTrigger.java Fix wrong action IDs in GitLabMergeRequestTrigger.java Nov 24, 2022
@mifitous
Copy link
Contributor Author

Hi @jetersen
rebased on master to avoid the noisy commit history
Thank you

@mifitous mifitous changed the title Fix wrong action IDs in GitLabMergeRequestTrigger.java Fix wrong action IDs in GitLabMergeRequestTrigger.java and add support to "approved" and "unapproved" as well Nov 27, 2022
@mifitous
Copy link
Contributor Author

@mifitous
Copy link
Contributor Author

Hi @jetersen : It will be very nice if you could review and merge please - it is blocking me for other tasks I must complete ASAP
Thank you !

@jetersen jetersen added the bug Something isn't working label Nov 29, 2022
@jetersen jetersen merged commit dc12a4a into jenkinsci:master Nov 29, 2022
@mifitous
Copy link
Contributor Author

mifitous commented Nov 29, 2022 via email

@jetersen
Copy link
Member

@mifitous Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants